Implementation of graphql-ws protocol #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 1240 1337 +97
=========================================
+ Hits 1240 1337 +97
Continue to review full report at Codecov.
|
Reset keep_alive timeout for each message received from backend
Put delays in variables in tests
Now saving ping, pong and connection_ack payloads in the transport class
Now using a factory method to create the countdown servers New answer_pings parameters of the transport to disable ping answers send_ping and send_pong are now public methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subscriptions-transport-ws used by the WebsocketsTransport class is apparently no longer actively maintained and the graphql-ws library is recommended instead.
This library uses a different websocket protocol.
It is possible to support both protocols from the client side by detecting which subprotocol has been chosen by the backend.